Opened 10 years ago

Last modified 3 years ago

#407 new enhancement

Auto remove "cannot connect-user" option upload list.

Reported by: Annoyed Owned by: quinox
Priority: minor Milestone: Release 1.3.0
Component: nicotine Version: SVN
Keywords: Cc:


Hello all,

Been having a problem with people who have not done their firewall right, resulting in them keeping up the upload list from me. As soon as someone tries to download from me and i cannot connect to them when sending the file, it tends to keep the list hanging on the same person and it is not moving on to the next user. The list freezes completely, which stops all uploads from me to all other users in the list.

Is it possible to write a script that removes a "cannot connect-user" or a "waiting for peer to connect-user" from the upload list after 30 seconds or so? That would really be helpful.

Not sure if this is a defect or not.

Change History (6)

comment:1 Changed 10 years ago by hedonist

Yeah, removing unresponsive peers from uploads would be a good idea. However it needs to be done carefully, because sometimes first few attempts to upload fail, but then it proceeds as normal.

comment:2 Changed 10 years ago by Annoyed

Maybe it is possible to base it on a number of attempts? And instead of removing them, put the uploads in a "paused mode" from the actual list and mark them as "connection failure"? That will enable the user to check less frequently on the upload activity, decide for themselfs what to do when this is noticed and without stopping the other uploads from continuing.

comment:3 Changed 10 years ago by hedonist

Another option is to move the user who got a 'cannot connect' outcome to the end of the queue. So that other users' uploads start, and the rest of his uploads are tried after that.

comment:4 Changed 10 years ago by Annoyed

If that does the trick, that would be a great solution. Does the queue system work the same for first in, first out and round robin?

I do think after some attempts of being moved back at the end of the queue a notification of this "cannot connect" outcome would be handy to both users. In case it is a firewall/router issue. Maybe implement the /scan option in it?

comment:5 Changed 10 years ago by hedonist

I just added a couple fixes that should solve this problem for "round robin" type queues. For FIFO it's a bit harder, and frankly I'm not interested in making that type of queue work well, or at all :)

comment:6 Changed 3 years ago by gfarmerfr

Milestone: Release 1.2.11Release 1.3.0
Note: See TracTickets for help on using tickets.