Opened 5 years ago

Closed 5 years ago

#532 closed task (fixed)

.glade files installed twice on Linux

Reported by: melmorabity@… Owned by: quinox
Priority: normal Milestone: Release 1.2.14
Component: nicotine Version: 1.2.14
Keywords: Cc:

Description

When installing Nicotine+ with a prefix root directory, .glade files are installed twice, whatever the root directory choosed.
This problem occurs on Fedora 12 (64 bits) with Python 2.6.2.

How to reproduice it?

  • build Nicotine+ :
    $ python setup.py build
    
  • install Nicotine+ in a particular root :
    $ mkdir /tmp/nicotine && python setup.py install --root=/tmp/nicotine
    
  • check the installed files :
    $ find /tmp/nicotine/ -iname "*.glade"
    /tmp/nicotine/usr/pynicotine/gtkgui/nowplaying.glade
    /tmp/nicotine/usr/pynicotine/gtkgui/search.glade
    /tmp/nicotine/usr/pynicotine/gtkgui/mainwindow.glade
    /tmp/nicotine/usr/pynicotine/gtkgui/privatechat.glade
    /tmp/nicotine/usr/pynicotine/gtkgui/nicotine-settings.glade
    /tmp/nicotine/usr/pynicotine/gtkgui/buddylist.glade
    /tmp/nicotine/usr/pynicotine/gtkgui/userbrowse.glade
    /tmp/nicotine/usr/pynicotine/gtkgui/chatrooms.glade
    /tmp/nicotine/usr/pynicotine/gtkgui/userinfo.glade
    /tmp/nicotine/usr/pynicotine/gtkgui/roomlist.glade
    /tmp/nicotine/usr/lib/python2.6/site-packages/pynicotine/gtkgui/nowplaying.glade
    /tmp/nicotine/usr/lib/python2.6/site-packages/pynicotine/gtkgui/search.glade
    /tmp/nicotine/usr/lib/python2.6/site-packages/pynicotine/gtkgui/mainwindow.glade
    /tmp/nicotine/usr/lib/python2.6/site-packages/pynicotine/gtkgui/privatechat.glade
    /tmp/nicotine/usr/lib/python2.6/site-packages/pynicotine/gtkgui/nicotine-settings.glade
    /tmp/nicotine/usr/lib/python2.6/site-packages/pynicotine/gtkgui/buddylist.glade
    /tmp/nicotine/usr/lib/python2.6/site-packages/pynicotine/gtkgui/userbrowse.glade
    /tmp/nicotine/usr/lib/python2.6/site-packages/pynicotine/gtkgui/chatrooms.glade
    /tmp/nicotine/usr/lib/python2.6/site-packages/pynicotine/gtkgui/userinfo.glade
    /tmp/nicotine/usr/lib/python2.6/site-packages/pynicotine/gtkgui/roomlist.glade
    

The files /tmp/nicotine/usr/lib/python2.6/site-packages/pynicotine/gtkgui/*.glade seem in the good place, not the /tmp/nicotine/usr/pynicotine/*.glade one.

I had to use the attached patch to prevent glade files from being installed in ROOT_PREFIX/usr/pynicotine/

Attachments (1)

nicotine+-1.2.14-glade_install.patch (687 bytes) - added by melmorabity@… 5 years ago.

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by melmorabity@…

comment:1 Changed 5 years ago by anonymous

I didn't have much understanding of the whole setup file when I made that change, must have screwed up at first, fixed it eventually but forgot to clean up the mess. I will verify and apply your patch at the end of the week when I get home.

Thanks for this ticket!

comment:2 Changed 5 years ago by quinox

  • Resolution set to fixed
  • Status changed from new to closed

Committed with r1356. I've also fixed the warning can't copy 'languages/nicotine-glade.pot/nicotine.mo': doesn't exist or not a regular file

Note: See TracTickets for help on using tickets.