aborted downloads 'come back' after a restart

[joss@…]

This is an old one, initially reported as http://bugs.debian.org/256048 but it is still here in 1.2.4.1.

To reproduce it, abort a download without clearing it from the window, quit nicotine and restart. The download starts again.

[daelstorm]

This is not a bug, it's expected operating procedure.

If you abort a download, all that means is you don't want to download it _now_, but you will later.

[joss@…]

I agree that it shouldn't be removed from the list, but this is not the problem.

When you restart nicotine, these downloads should come back as still aborted, instead of starting automatically. An even more annoying behavior is that they start automatically after a server disconnect/reconnect cycle, which can this happen without any user interaction at all.

[gandalf]

I agree.

But I guess daelstorm can't do this due to protocol limitations.

[daelstorm]

Nothing to do with protocol limitations, and now that I understand the problem I've tried to fix it. Unfortunantly, I haven't found a way to implement this. Nicotine's Transfer code, like museek's is complex and confusing. Adding to the 1.3.0 milestone.

[daelstorm]

fixed back for the 1.2.7 release