Modify

Ticket #284 (closed task: fixed)

Opened 3 years ago

Last modified 3 years ago

Implement search results limit

Reported by: quinox Owned by: daelstorm
Priority: major Milestone: Release 1.3.0
Component: nicotine Version:
Keywords: Cc:

Description

Now n+ doesn't lock up anymore on generic search terms we need to be able to control the maximum amount of search results to prevent n+ from becoming difficult to interact with

Attachments

Change History

comment:1 Changed 3 years ago by offhand

can't that be done in Settings > Misc > Searches?

comment:2 Changed 3 years ago by quinox

I guess my bug report wasn't too clear. The one you're referring to is the outgoing search limit, I'm talking about a different ones:

  • Limit the amount of incoming search results
  • Limit the amount of incoming search results shown

If possible I like feature 2, but feature 1 would work as well. The difference between the two should be clear when using filters, with 1 you'll get a lot less results whereas with feature 2 you'll always get up to $maximum

comment:3 Changed 3 years ago by quinox

  • Status changed from new to closed
  • Resolution set to fixed

Implemented with r861 . The amount of search results that are stores is currently 1500, of which a maximum of 500 are displayed. There will still be a noticeable but short slowdown with search terms like 'Madonna' when processing the avalanche of incoming results, but a real freeze or lockup shouldn't happen anymore. We might make the limits configurable in the future, or crank them up for everybody if it's deemed too low.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.