Ticket #228 (closed defect: fixed)

Opened 11 months ago

Last modified 5 weeks ago

Wrong ordering for the buttons

Reported by: joss@… Owned by: daelstorm
Priority: major Milestone:
Component: nicotine Version:
Keywords: Cc:

Description

The buttons ordering in dialogs (preferences) is reversed from the other GTK+ apps. Even in stock dialogs like the file chooser, they are reversed. This is also very annoying in the exit confirmation dialog. Not only this dialog is annoying in itself, but you have to read it each time because the buttons are not placed in a consistent ordering, which would be : “To system tray” - “Cancel” - “OK”.

More information on button ordering can be found in the HIG book, section 3.6.1.

Attachments

nicotine-hig.diff (5.7 kB) - added by joss@… 10 months ago.
Patch to fix button ordering

Change History

Changed 11 months ago by daelstorm

  • status changed from new to closed
  • resolution set to wontfix

I'm afraid I don't use GNOME, or the GNOME HIG.

While I understand many people do use GNOME, and do enjoy that 'arrangement', I don't care for it. Nicotine+ isn't a GNOME app.

If someone wants to change that, by all means do.

Changed 10 months ago by joss@…

Patch to fix button ordering

Changed 10 months ago by joss@…

  • status changed from closed to reopened
  • resolution wontfix deleted

The HIG is not a GNOME-specific document; especially the part about buttons is here to make all possible applications use the same button ordering for consistency matters.

Nicotine uses a different button ordering from most GTK+ applications; for some dialogs like the file chooser, this is very confusing and you're most likely to hit the wrong button regularly.

I have attached the patch that brings the correct ordering.

Changed 5 weeks ago by quinox

  • status changed from reopened to closed
  • resolution set to fixed

Thanks a lot for the patch, applied :-)

Add/Change #228 (Wrong ordering for the buttons)

Author



Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.